Fix InsecureSSL default for GitHub webhooks#3148
Fix InsecureSSL default for GitHub webhooks#3148intojhanurag wants to merge 1 commit intoknative:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: intojhanurag The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @intojhanurag. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3148 +/- ##
==========================================
+ Coverage 59.35% 60.12% +0.76%
==========================================
Files 134 134
Lines 13519 13519
==========================================
+ Hits 8024 8128 +104
+ Misses 4552 4420 -132
- Partials 943 971 +28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/retest |
|
/ok-to-test |
|
@matejvasek @lkingland can we do this? not sure if it used to break something beforehand or why havent we done this prior |
aee061c to
fa82bb5
Compare
Changed
InsecureSSLfrom "1" (insecure) to "0" (secure) to ensure SSL certificatesare properly verified by default.