Skip to content

Fix InsecureSSL default for GitHub webhooks#3148

Closed
intojhanurag wants to merge 1 commit intoknative:mainfrom
intojhanurag:fix/insecure-ssl
Closed

Fix InsecureSSL default for GitHub webhooks#3148
intojhanurag wants to merge 1 commit intoknative:mainfrom
intojhanurag:fix/insecure-ssl

Conversation

@intojhanurag
Copy link
Copy Markdown
Member

Changed InsecureSSL from "1" (insecure) to "0" (secure) to ensure SSL certificates
are properly verified by default.

@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented Oct 25, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: intojhanurag
Once this PR has been reviewed and has the lgtm label, please assign gauron99 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot requested review from dsimansk and nainaz October 25, 2025 06:24
@knative-prow knative-prow Bot added size/XS 🤖 PR changes 0-9 lines, ignoring generated files. needs-ok-to-test 🤖 Needs an org member to approve testing labels Oct 25, 2025
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented Oct 25, 2025

Hi @intojhanurag. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 25, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 60.12%. Comparing base (3d1ee5e) to head (fa82bb5).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/git/github/github.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3148      +/-   ##
==========================================
+ Coverage   59.35%   60.12%   +0.76%     
==========================================
  Files         134      134              
  Lines       13519    13519              
==========================================
+ Hits         8024     8128     +104     
+ Misses       4552     4420     -132     
- Partials      943      971      +28     
Flag Coverage Δ
e2e-tests 41.62% <0.00%> (+1.42%) ⬆️
integration-tests 54.65% <0.00%> (+1.65%) ⬆️
unit-tests 46.71% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gauron99
Copy link
Copy Markdown
Contributor

/retest

@gauron99
Copy link
Copy Markdown
Contributor

/ok-to-test

@knative-prow knative-prow Bot added ok-to-test 🤖 Non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test 🤖 Needs an org member to approve testing labels Oct 30, 2025
@gauron99
Copy link
Copy Markdown
Contributor

@matejvasek @lkingland can we do this? not sure if it used to break something beforehand or why havent we done this prior

@gauron99 gauron99 requested review from lkingland and matejvasek and removed request for dsimansk and nainaz November 1, 2025 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test 🤖 Non-member PR verified by an org member that is safe to test. size/XS 🤖 PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants